Fix: Lambda Topology Issue #173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Lambda Topology issue -- PRs in other ADOT SDKs:
Description of changes:
Test plan:
Set up two Lambda functions with .NET runtimes and tested with custom Lambda layer with fix built-in. Below are screenshots of the topology for various configurations.
We observe the following correct behaviors for topology above:
Invokecall to downstream lambda.GetFunctioncall to downstream lambda.ListBucketscall to downstream s3.We observe the following correct behaviors for topology above:
Invokeis correctly treated as RemoteService entity when not instrumentedWe observe the following correct behaviors for topology above:
Validated that the correct trace is generated for lambda instrumentation patch. This trace is for
GetFunctioncall.I could not validate
Invokedirectly since the .NET sample app sends the traces to CloudWatch via EC2 instance which conflicts with the Lambda environment. However, the above Topology behaviors and EMF Logs are sufficient to confirm the intended behavior.InvokeEMF LogsGetFunctionEMF LogsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.